Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Error::description #376

Merged

Conversation

AnderEnder
Copy link
Contributor

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.

This PR:

  • Removes all implementations of description in all error types

Related PR: rust-lang/rust#66919

@quodlibetor
Copy link
Contributor

It's still required in rust 1.13, I think, we should maybe add #[allow(deprecated)] to description until chrono 0.5 and maybe create an issue to remove it in the next release.

@AnderEnder
Copy link
Contributor Author

@quodlibetor, I think the minimal version should be increased to 1.27.0. I do not think so ancient version should be still supported.

@quodlibetor
Copy link
Contributor

@AnderEnder the next minor release of chrono will definitely pin to a newer compiler, and possibly update the backcompat policy. For now, though, I do take back-compat very seriously and still support ancient rust in the 0.4 branch.

@quodlibetor quodlibetor merged commit 6daed98 into chronotope:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants