Deprecate standalone format
functions
#1306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #1163.
In the
format
module we have 4 standaloneformat*
functions. I don't think they were ever intended to be public.They need an
&mut Formatter<'_>
as argument, which can't be constructed outside of aDisplay
implementation.To deprecated these methods I inlined them in
DelayedFormat::Display
, and made the methods wrappers around that.