Deprecate standalone format functions
#1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
changed the title
format functions
pitdicker
force-pushed
the
deprecate_format_functions
branch
from
da889fe
to
fe3cef2
Compare
|
Oops, 0.4.28 is no longer the next version to mentions in the deprecation 🤣. |
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1306 +/- ##
==========================================
- Coverage 91.30% 91.00% -0.30%
==========================================
Files 38 38
Lines 17044 17068 +24
==========================================
- Hits 15562 15533 -29
- Misses 1482 1535 +53
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pitdicker
force-pushed
the
deprecate_format_functions
branch
from
fe3cef2
to
ffbed1b
Compare
djc
approved these changes
Sep 22, 2023
src/format/formatting.rs
Outdated
| @@ -161,6 +161,7 @@ impl<'a, I: Iterator<Item = B> + Clone, B: Borrow<Item<'a>>> Display for Delayed | |||
| /// Internally used by `DelayedFormat`. | |||
| #[cfg(any(feature = "alloc", feature = "std"))] | |||
| #[cfg_attr(docsrs, doc(cfg(any(feature = "alloc", feature = "std"))))] | |||
| #[deprecated(since = "0.4.32")] | |||
There was a problem hiding this comment.
Let's add a note about what to use instead?
pitdicker
force-pushed
the
deprecate_format_functions
branch
from
ffbed1b
to
30f51db
Compare
pitdicker
force-pushed
the
deprecate_format_functions
branch
from
30f51db
to
0aae70b
Compare
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #1163.
In the
formatmodule we have 4 standaloneformat*functions. I don't think they were ever intended to be public.They need an
&mut Formatter<'_>as argument, which can't be constructed outside of aDisplayimplementation.To deprecated these methods I inlined them in
DelayedFormat::Display, and made the methods wrappers around that.