Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝(content) ChromeOS lint rules in Android Studio #576

Merged
merged 17 commits into from
Jan 20, 2023

Conversation

jkcinouye
Copy link
Collaborator

@jkcinouye jkcinouye commented Dec 8, 2022

Please describe what your Pull Request does

  • Add blog post: ChromeOS lint rules in Android Studio
  • Add Android-Environment post: Lint rules for ChromeOS in Android Studio
  • Add author: Josh Hale (jhale) to contributors.js.

Please tag each issue this Pull Request resolves

  • Resolves #

Copy link
Collaborator

@Snugug Snugug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is why stuff's failing: this needs to be one line

@jkcinouye
Copy link
Collaborator Author

These are otherwise ready to be staged/pushed except for the images.

Copy link
Collaborator

@Snugug Snugug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with image links

@jkcinouye jkcinouye marked this pull request as ready for review January 3, 2023 23:24
@jkcinouye jkcinouye requested a review from a team as a code owner January 3, 2023 23:24
@jkcinouye
Copy link
Collaborator Author

@Snugug Can you tell why this is still choking? I'm sure it's something dumb I'm missing.

Copy link
Collaborator

@Snugug Snugug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this'll fix the build

@github-actions
Copy link

github-actions bot commented Jan 11, 2023

Visit the preview URL for this PR (updated for commit 7d308e0):

https://cros-staging--pr576-jkcinouye-content-ch-0s6c4450.web.app

(expires Sun, 19 Feb 2023 16:23:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 885bb271e567405677d117cfd5af5c57785d13e2

@jkcinouye jkcinouye requested a review from Snugug January 12, 2023 18:26
@Snugug Snugug merged commit c9c7f17 into main Jan 20, 2023
@Snugug Snugug deleted the jkcinouye-content-chromeos-lint-rules branch January 20, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants