Upgrade prettier, fix "format" CLI action, format files #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
changed the title
kylesuss
force-pushed
the
upgrade-prettier
branch
from
e179346
to
6a71473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought that this repo needed a
.prettierrcas I was getting inconsistent results between my editor and thenpm run formatcommand. Now that I know that the repo is using eslint to run theprettierchecks, it makes sense to havenpm run formatuse theprettier-eslintCLI rather than justprettieras the latter does not know where to look for the config!That is fixed in this PR along with a few old, offending files. Also, I updated a few
prettierpackages.