Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular code #2

Closed
domyen opened this issue Apr 3, 2018 · 5 comments
Closed

Angular code #2

domyen opened this issue Apr 3, 2018 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@domyen
Copy link
Member

domyen commented Apr 3, 2018

Angular users, we need your help converting the LearnStorybook example code. 🙏

The example is currently written in React and Redux. If you use Angular (and a little React) and have a grasp on its state management ecosystem help us introduce Storybook to that community.

Comment below!

@domyen domyen added the help wanted Extra attention is needed label Apr 3, 2018
@alterx
Copy link
Contributor

alterx commented Jul 24, 2018

Hey @domyen, I helped bringing Angular to Storybook and would love to contribute here. I've also done a ton of React work so it shouldn't be an issue to convert the code :)

I don't have a lot of free time but will start looking into the code. Is there anything I should know before starting?

@tmeasday
Copy link
Member

Hey @alterx, great to hear from you!

I'm glad you asked. I've been (slowly) looking at trying to get the Vue version integrated as contributed by @mattrothenberg broken up into steps to match our chapters (see
#1 (comment))

The thing that takes a little while is just getting every step working in a simple reproducable way for users. In particular the first chapter where you run a few commands and end up with working app and storybook and jest environment---this wasn't quite as easy in Vue as it was in React (at least for me, who isn't a Vue user).

So basically what I am trying to say is there are a few levels of work that need to be done:

  1. Getting the final app&storybook as per https://github.com/chromaui/learnstorybook-code running in an angular environment w/ equivalent code (e.g. replacing Redux w/ something that makes sense for angular, etc). This bit I definitely can't do myself and is the most important!

  2. Getting the code from above broken up into commits that match up with the chapters and are easy for the user to follow with simple steps. I appreciate this is a pain and I am happy to do it myself although I suspect you will be better at it than me!

  3. Writing the corresponding text to 2. This is easier to do at the same time as 2, but also I am more than happy to do it.

Does that make sense? Please hit me up here or on storybook slack if there are any specific questions!

@alterx
Copy link
Contributor

alterx commented Jul 25, 2018

Hey @tmeasday, long time no see (chat 😂) !

I like the idea of having a commit per title, it feels like it's going to help a lot. As of the work that needs to be done, I intend to work on the three parts. It's probably easier (and just faster) for the person that wrote the app to work on 2 and 3.

I'll start with the app and hit you up on Slack if I have further questions :)

@alterx
Copy link
Contributor

alterx commented Jul 27, 2018

The code is here chromaui/learnstorybook-code#4
Will also add changes for the site on this repo.

@domyen
Copy link
Member Author

domyen commented Aug 6, 2018

Thank you @alterx! 🙏 Closing this ticket

@domyen domyen closed this as completed Aug 6, 2018
domyen pushed a commit that referenced this issue Jan 28, 2020
jonniebigodes pushed a commit that referenced this issue Jun 17, 2022
* ui-testing-handbook 의 7장 automate 초벌 번역

* 넘아가면 오타 수정, CI 한국어와 병기

* 어미 수정

* workflow 번역

* conclusion 완료

* 리뷰 반영

Co-authored-by: Taehee Kim <[email protected]>
jonniebigodes pushed a commit that referenced this issue Feb 8, 2024
Fix issues wrotes by jonniebigodes - 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants