This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Tags join & bower ignore filter #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 16, 2015 15:45
Ignore filter adjusted to include only needed
pepelsbey
changed the title
christian-fei
added a commit
that referenced
this pull request
Feb 16, 2015
Tags join & bower ignore filter
|
Thank you very much 👍 !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags join
Since
array_to_sentence_stringis making listone, two and three(who needs “and” for a pure data?) andjoin: ', 'is just joining array to a string with,as a separator.Bower ignore filter
No one needs source files and JSON data samples in bower package, there are only two needed files:
That’s why ignore filter is adjusted accordingly:
And package size went down from 25 to 10 KB.