Some optimizations using JS over jQuery. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2016 16:33
This will give you a better performance, and at the same time, allow you to use jQuery. (https://stackoverflow.com/questions/1854859/jquery-performance-wise-what -is-faster-getelementbyid-or-jquery-selector)
Hope I didn’t mess anything up. Seems to be working fine for me. I tried to think it through before doing anything too crazy.
chrisdiana
added a commit
that referenced
this pull request
Jan 27, 2016
Some optimizations using JS over jQuery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isPlainObject in Pure Javascript.
Simply put, this test convinced me to replace it: https://jsperf.com/jquery-is-plain-object-vs-javascript-way
Results:
Some optimizations.
Worked on the loops and managed to eliminate some of them. Got one jQuery each replaced with pure JS. I tried several of the others, but didn't have much luck.
Get elements using pure JS within
$().This will give you a better performance, and at the same time, allow
you to use jQuery.
(https://stackoverflow.com/questions/1854859/jquery-performance-wise-what
-is-faster-getelementbyid-or-jquery-selector)