Replace nav string concatenation with join(). #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 23, 2016 23:41
According to a Google JS optimization guide, join() is better than doing += to a running string when it is passing through a loop or conditional statement. Reference: https://developers.google.com/speed/articles/optimizing-javascript
I noticed that the similar switches are already used in other parts of the code, plus, technically switch is faster (albeit not noticeable).
General idea here: shorter and more professional vocabulary. An example would be to avoid using the word: stuff.
chrisdiana
added a commit
that referenced
this pull request
Jan 25, 2016
Replace nav string concatenation with join().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a Google JS optimization guide,
join()is better than doing+=to a running string when it is passing through a loop orconditional statement.
Reference:
https://developers.google.com/speed/articles/optimizing-javascript