Documentation #17
Merged
Documentation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. |
agross
reviewed
Oct 11, 2018
| @@ -38,7 +38,7 @@ if ls $(dirname $0)/nsupdate.d/*.config &> /dev/null; then | |||
| for f in $(dirname $0)/nsupdate.d/*.config | |||
| do | |||
| if [[ "$SILENT" == "NO" ]]; then | |||
| echo "Starting nameserver update with config file $f" | |||
| echo "Starting nameserver update with config file $f ($LOG)" | |||
There was a problem hiding this comment.
When you override LOG in the config file this will log the wrong file (e.g. the default log file for the first config).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
thanks for your awesome work. I've added and re-written some documentation along with a minor code change (I had no idea about the log file until I saw that tiny
>> $LOG). Hope you like it.Regards,
Christoph