Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for a full bankai build #497

Merged
merged 8 commits into from
Jun 1, 2018
Merged

Add tests for a full bankai build #497

merged 8 commits into from
Jun 1, 2018

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented May 30, 2018 •
edited
Loading

This adds some basic tests for bankai build, specifically things that
have been broken in the past:

  • bankai build app/ and bankai build app/index.js should both output
    to the same directory app/dist by default
  • bankai build outputs dynamic bundles created with split-require
  • tests pass
  • tests and/or benchmarks are included

@goto-bus-stop goto-bus-stop merged commit 4940fa3 into master Jun 1, 2018
@goto-bus-stop goto-bus-stop deleted the build-tests branch June 1, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@goto-bus-stop