Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed + more consistent basedir handling #467

Merged
merged 5 commits into from
May 8, 2018
Merged

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Apr 13, 2018

This is a 🐛 bug fix

When the entry point is given as a directory, the build destination
dist and asset paths would be calculated relative to the parent
directory. With this patch, the default build destination is ./dist
relative to the entry point file, and assets are served from ./assets
relative to the entry point file.

Ensures that these:

bankai build example/index.js
bankai build example

both do the same thing.

Checklist

  • tests pass
  • tests and/or benchmarks are included

Context

14:14 < louisc> I'm having an issue with bankai whereby if I try and
  access a file in the `assets` directory, bankai will try and serve
  the asset from the wrong filepath
14:15 < louisc> for example, if I'm running bankai from ~/dev/mywebsite,
  it will try and load assets from ~/dev/assets, rather than
  ~/dev/mywebsite/assets
14:15 < louisc> I'm using v9.10.7
14:16 < louisc> I'm wondering if this is to do with the change in
  9.10.4 that dealt with asset pathing?
14:17 < louisc> cc benlyn goto-bus-stop
14:18 < goto-bus-stop> louisc: o, possibly
14:19 < goto-bus-stop> louisc: does it work correctly if you do
  `bankai start ~/dev/mywebsite/index.js` instead?
14:19 < louisc> goto-bus-stop: yes

Semver

Patch

@goto-bus-stop goto-bus-stop merged commit 73b34cc into master May 8, 2018
@goto-bus-stop goto-bus-stop deleted the fix/basedir branch May 8, 2018 08:39
@goto-bus-stop goto-bus-stop mentioned this pull request May 25, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant