Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read custom html templates #447

Merged
merged 5 commits into from
Mar 14, 2018
Merged

Read custom html templates #447

merged 5 commits into from
Mar 14, 2018

Conversation

goto-bus-stop
Copy link
Member

This uses $route.html for server side rendering.

TODO: also try index.html if $route.html does not exist, before falling back to the default empty document.

yoshuawuyts
yoshuawuyts approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goto-bus-stop goto-bus-stop merged commit 8cbfa5c into master Mar 14, 2018
@goto-bus-stop goto-bus-stop deleted the custom-html branch March 30, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @yoshuawuyts