Move UI code out of http.js #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice thanks! |
7b9a643
to
de3b54d
Compare
de3b54d
to
ff915e5
Compare
1 task
346574b
to
c4a3764
Compare
c4a3764
to
dcf2838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the UI
statestuff into lib/ui.js. the live reload connection counterstate.sseis still managed by http.js, it emitssse-connectandsse-disconnectwhen the value updates so the UI can rerender. Maybe the counting should also happen in the UI code, with http.js only emitting those events?Also added in @Flet's simple log output UI, just to make sure that the UI is indeed separate from the HTTP server now :)