Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag off uglifyify #158

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Flag off uglifyify #158

merged 1 commit into from
Apr 14, 2017

Conversation

toddself
Copy link
Contributor

Add a flag to prevent uglifyify from running on the assets to let people run
es6 code more easily.

@yoshuawuyts
Copy link
Member

Oh, the way I was thinking to do this would be to set uglify as a boolean, and default to true - never been a fan of the negate-flags haha. E.g. the API would become:

$ bankai start --uglify=false index.js

@yoshuawuyts
Copy link
Member

yoshuawuyts commented Apr 11, 2017

Oh, also this would need to be documented in the bin.js help text, and readme.md help text + API

Add a flag to prevent uglifyify from running on the assets to let people run
es6 code more easily.
@toddself
Copy link
Contributor Author

Oh good point. The flag has been changed to be like watch, and the README is updated now with a note about ES5 syntax.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neattttt!

@yoshuawuyts yoshuawuyts merged commit 2263f1e into choojs:master Apr 14, 2017
@yoshuawuyts
Copy link
Member

v7.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants