Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed in support of alchemiscale-fah #45

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Conversation

dotsdl
Copy link
Member

@dotsdl dotsdl commented Apr 12, 2024

This PR contains all changes needed for alchemiscale-fah MVP support.

@dotsdl dotsdl changed the title Changes needed in support of alchemiscale-fah [WIP] Changes needed in support of alchemiscale-fah Apr 12, 2024
@dotsdl dotsdl self-assigned this Apr 16, 2024
@dotsdl
Copy link
Member Author

dotsdl commented Apr 30, 2024

@ijpulidos can I get an initial review on this one? I'm not sure we'll need any additional changes in feflow in support of openforcefield/alchemiscale-fah#7, but I'll keep it in [WIP] state until I'm certain of that. A review will still be helpful to ensure there aren't any obvious gaps in the changes here.

@dotsdl dotsdl requested a review from ijpulidos April 30, 2024 15:40
@dotsdl
Copy link
Member Author

dotsdl commented Apr 30, 2024

Actually, I think @ijpulidos is on vacation starting today; can I get a review from you instead @IAlibay?

@dotsdl dotsdl requested review from IAlibay and removed request for ijpulidos April 30, 2024 15:41
@dotsdl dotsdl added this to the 0.1.0 release milestone Apr 30, 2024
@dotsdl dotsdl changed the title [WIP] Changes needed in support of alchemiscale-fah Changes needed in support of alchemiscale-fah Jul 9, 2024
@dotsdl
Copy link
Member Author

dotsdl commented Jul 9, 2024

@ijpulidos I think it's safe this is ready for merge! It's unclear to me why the CI isn't passing, however; is this something you have any insights on?

@ijpulidos
Copy link
Contributor

ijpulidos commented Jul 9, 2024

@dotsdl The CI failing is because we have temporarily dropped support for GAFF, but we are still using it in our tests and these are not easy to adapt without some non-trivial amount of work. Thats also why it's working with older python (which install older versions of the dependencies and GAFF that work fine).

The changes in this PR are unrelated to that issue, this should be ready to be merged. LGTM!

@ijpulidos ijpulidos merged commit ed21b98 into main Jul 9, 2024
2 of 6 checks passed
@ijpulidos ijpulidos deleted the alchemiscale-fah branch July 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants