Skip to content

Commit

Permalink
Add CONTRIBUTING.md with instructions for contributors.
Browse files Browse the repository at this point in the history
  • Loading branch information
chimbori committed Jan 28, 2017
1 parent d0cd337 commit 2241e41
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Contributing to Crux

Crux is a modern, robust library for parsing HTML articles. With all the content on the Web out there, there is always lots of room for improvement. We will gladly accept your pull requests that make parsing more accurate, or add new features & metadata detection.

To maintain the integrity of the library, we have a few simple expectations from all code submitted.

1. Crux follows the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html). All new code should adhere to this guide. Please note rules around indentation (2 spaces, no tabs) and that braces are required around single-line clauses, e.g.:
```java
if (condition) {
x = 0; // Braces are required around this line.
}
```

1. Crux is fully unit-tested, and we want to keep it that way. All new code should include unit tests.
1. For parsing improvements, Crux’s rich suite of integration tests should be updated to reflect the parsing changes. Authors may either choose to test their improvements within existing HTML test files, or add new ones, as appropriate.
1. All current tests should continue to pass. Either update the tests in the same CL, or modify the new code, so that existing tests continue to pass.
1. Changes should be self-contained, as far as possible. When implementing multiple independent improvements, each one should be in its own PR.

0 comments on commit 2241e41

Please sign in to comment.