Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IPv4/IPv6 interface config (dev only) #231 #232

Merged

Conversation

d47081
Copy link

@d47081 d47081 commented Dec 10, 2023

#231

At this moment, implemented for dev server only

@programarivm programarivm merged commit 46bc4a5 into chesslablab:master Dec 11, 2023
2 checks passed
@programarivm
Copy link
Member

Thank you @d47081 for contributing to this repo.

WS_LISTEN has been renamed to WS_ADDRESS.

See https://github.com/ratchetphp/Ratchet/blob/master/src/Ratchet/Server/IoServer.php#L57

Keep it up,

@d47081
Copy link
Author

d47081 commented Dec 11, 2023

@programarivm and thanks to you for this amazing product!

Just imo it's better to call it LISTEN because option related to interface where connections coming from and ADDRESS is the mostly common definition and can have many of interpretations

It's also more clear for linux administrators by netstat -tulpn | grep LISTEN

Anyway, would be nice to explain config file with comments as I've played lot of time before launched the instance.

upd.

https://github.com/ratchetphp/Ratchet/blob/master/src/Ratchet/Server/IoServer.php#L57

okay, if that's more native for library users - I'll update the docs drafted for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants