add jsdoc and import and use validUrl function in About and Biopost

src/libraries/utils.js

@@ -1,11 +1,18 @@
-// Our CMS does not validate urls,
-// urls are entered in manually by the author,
-// so this is to ensure a valid url to navigate to
-const validPortfolioUrl = (url = "") => {
+ /**
+ * Our CMS does not validate urls,
+ * urls are entered in manually by the author,
+ * so this is to ensure a valid url to navigate to
+ * @function
+ * @param {string} url - The url of the portfolio site
+ * @returns {string} url - The passed in url or a new url 
+ * with https appended to it
+ */
+ export const validUrl = (url = "") => {
  const https = "https://";
+ const trimmedUrl = url.trim();
 
- if (url.includes(https) || url.includes("http:https://")) {
+ if (trimmedUrl.includes(https) || trimmedUrl.includes("http:https://")) {
  return url;
  }
- return https + url;
+ return https + trimmedUrl;
  };

src/pages/About.vue

@@ -47,7 +47,7 @@
  <a
  class="ml-auto text-xl font-extrabold"
  v-if="member.node.contact_links.portfolio_url"
- :href="member.node.contact_links.portfolio_url"
+ :href="validUrl(member.node.contact_links.portfolio_url)"
  >site</a
  >
  </article>
@@ -86,9 +86,14 @@ query
 </page-query>
 
 <script>
+import {validUrl} from "../libraries/utils"; 
 export default {
  metaInfo: {
  title: "About us",
  },
+ methods: {
+ validUrl
+ }
+
 };
 </script>

src/templates/Biopost.vue

@@ -16,13 +16,13 @@
  />
  <a
  v-if="$page.biopost.contact_links.email"
- :href="`mailto:${$page.biopost.contact_links.email}`"
+ href="`mailto:${$page.biopost.contact_links.email}`"
  class="font-bold underline"
  >Email</a
  >
  <a
  v-if="$page.biopost.contact_links.portfolio_url"
- :href="$page.biopost.contact_links.portfolio_url"
+ :href="validUrl($page.biopost.contact_links.portfolio_url)"
  class="font-bold underline"
  >Portfolio</a
  >
@@ -63,12 +63,16 @@
 </template>
 
 <script>
+import {validUrl} from "../libraries/utils";
 export default {
  metaInfo() {
  return {
  title: this.$page.biopost.title,
  };
  },
+ methods: {
+ validUrl
+ }
 };
 </script>