-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.4.0 #392
Release 1.4.0 #392
Conversation
…bmodule. Added code examples to docstrings. Added 'pipelines' property.
…t.new_pipelines() to avoid confusion.
…anging the property which affects the resolution.
Make EFITEquilibirum.f_profile available to users.
Fix f_profile definition in EFITEquilibrium docstring and changelog.
…lised line shape.
Fix Bremsstrahlung trapezium indexing
…. Tweak core profile parameters.
…itched to use pre-calculated core profiles by default.
* Update python and numpy versions in CI - Remove Python 3.6 - Only test oldest and newest supported numpy versions * Update pyopencl version in CI v2022.2.4 fixes POCL library not found issue. * Use newest pre-built numpy in CI Add --prefer-binary flag when installing dependencies, to avoid trying to build newer numpy versions from source on older Pythons.
I decided to do new PR, because at the end there were many changes: laser geometry is now segmented cylinder as suggested by @mattngc. This propagated into handling of information between plasma, laser node, laser model and scattering model. This was neccessary to simplify handling of notifications, deletions and etc. laser model and spectrum hold no plasma and laser reference. Their methods return requested properties (e.g. laser power) in laser node frame. Laser material now obtains all the information from plasma, laser spectrum and laser model needed by the scattering model. Scattering model works in the frame of reference of the laser node. Method for scattered spectrum calcullation must now get all the neccessary plasma and laser variables (e.g. Te, ne, directions, etc.) laser models were rewritten and new added (uniform, bivariate and trivariate normal spatial distributions, Gaussian beam model). Lasers are now described by pulse energy and pulse temporal lengh, this is transformed to spatial power densities using given distributions. laser spectrum power spectral density was corrected. Unittests checking the following were added: laser node initialisation propagation of notifications between laser model, laser spectrum, scattering model, laser geometry and laser material position of the laser segments compared to the expected one laser spectrum initialisation and changes normalisation of models laser models initialisation polarisation direction correct values of power for spatial points integration of laser power over pulse spatial extent is compared to expected pulse energy scattering model scaterred spectrum traced by a ray is compared to expected values calculated by semi-analytical approach.
Add classes for common spectroscopic instruments
Add more accurate Gaunt factor for Bremsstrahlung emission model
Add Gaussian quadrature integration for line shape models
Add full profiles for Generomak plasma
@jacklovell, I just noticed that "Bug fixes" section is repeated twice in changelog.md. Also, "Fix wavelength indexing in Bremsstrahlung emission model. (#352)" and "Fixed Bremsstrahlung trapezium evaluation (#384)." are fixing the same bug. Keep only the last one. |
Good catch. I'll fix that. I'll also go through the commit history and check that all the changes are accurately reflected in the changelog. |
Cherab 1.4.0rc1 has been uploaded to PyPI: sdist and manylinux wheels for Python 3.7, 3.8, 3.9 and 3.10. 3.10 is built on manylinux2014 as earlier ones couldn't build the wheel due to dependency issues: the others are built on manylinux1 to match Raysect. Please test these by running |
I tested it on the ITER cluster and everything works fine. The only thing I noticed, |
Sorry for the delay. I tested the releaset with major python distributions we use at COMPASS and all seems to be fine, so from my side I think we can go ahead. |
No description provided.