-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.0 #184
Merged
Merged
Release v1.2.0 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eq.psin_to_r` only exists if psin is monotonic, which is not generally the case. This commit simply adds a check for this, and avoids plotting psin vs R if psin is not monotonic.
rates and emission rates. Towards (#79).
Fix plotting equilibria with detail=True for non-monotonic psi.
Update the import_eqdsk function to match EFITEquilibrium instantiation. At the same time, make the function more robust to NaN values being present in the EQDSK file, as well as the possibility that the LCFS and/or limiter are not provided.
Otherwise, raise a warning that the interpolation for a profile containing NaNs will be broken.
Fix reading G EQDSK files into EFITEquilibrium objects
Plotting a voxel collection previously would fail on Python 3.7 with Numpy 1.15.4 with a "truth table of an array is ambiguous" error when voxel_values were supplied as a Numpy array. The test should be for the colours being present, rather than indirectly via the voxel_values being present.
Fix voxel grid plotting colourbar logic
Relabeling the atomic rate coefficients to distinguish between process
Feature/radiated power
This has almost the same interface as the NNLS inversion routine, but drops the non-negativity constraint. It is still a linear least squares inversion. The only difference is that the residuals returned from lstsq are an array of dimensions which depend on the inputs.
Add least squares inversion routine
context of an ion. This is to prevent a name class between the ion's charge state and the atomic process of ionisation. Fixes cherab/openadas#21.
Refactoring the variable name 'ionisation' to be 'charge' in the
Adding a ThermalCXRate coefficient and associated interface.
Feature/more samplers
…nt in the plasma.
Also correcting the units for PECs.
…_maxdistance Add max_distance option to BolometerFoil.calculate_etendue
Fix Discrete2DMesh import
Fix trace_sightline ray displacement
Enhancement/voxel performance
Ensure that the set_active behaviour of ToroidalVoxelGrid.__init__ matches that of ToroidalVoxelGrid.set_active: the voxel material and parent should be set correctly for both active="all" and active=<int>. Also add some unit tests for ToroidalVoxelGrid.
Fix setting voxel emitter material and parent in init
Fixing bug with broken import in beam.py demo (fixes #180).
…ibility issues with future releases..
* Added Ray Transfer Matrices (alternative to voxel collections) * Added unit tests for Ray Transfer Matrices * Small changes in demos. Some corrections in docstrings. Documentation for Ray Tranfer Objects and demos. * Corrected some misprints in documentation * Improved and renamed ray transfer emitters and integrators. Corrected docstrings. Improved documentation. * Removed access to protected attributes of parent classes in the derived ones * Added variables to docstrings * Improved docstrings * Added integration to ray transfer tests * Removed duplicate methods from RTOptimisedRoughConductor and added wavelength range check. Improved documentation.
# Conflicts: # README.md
…matically trigger it, leading to inconsistent behaviour vs source packages. Updated installation instructions.
… governance model for the next release.
CnlPepper
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All expected changes for the next release have now been merged.
@CnlPepper, please review and consider making a new release for cherab.