Fix databag globbing issues for chef-solo on windows #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a spec failure on windows and then chefstyle updates, but please let's get this merged! :) |
|
@lamont-granquist and I have already 👍 the original, so I think you can merge as soon as the above are happy |
|
@jaym it looks to me like the code is correct, but your spec is testing the wrong behavior. if you just fix the spec you can merge. 👍 |
jaym
force-pushed
the
jdm/4915
branch
2 times, most recently
from
c3cde5f
to
de67115
Compare
This was testing `escape_glob` behavior. Probably a copy-pasta mistake
jaym
added a commit
that referenced
this pull request
Feb 17, 2016
Fix databag globbing issues for chef-solo on windows
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backslashes should not be passed to Dir, as it does not work
when globbing in many cases.
Created new function that can be used with dir on windows.
escape_glob_dirshould be used when the result is goingto be passed into Dir.
Fixes #4194
Replaces #4195