Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating all templates for Packer 1.1.0 #905

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Updating all templates for Packer 1.1.0 #905

merged 1 commit into from
Sep 22, 2017

Conversation

cheeseplus
Copy link
Contributor

Adds expect_disconnect to all script provisioners because we do reboots and don't want that to blow up.

Signed-off-by: Seth Thomas [email protected]

@rickard-von-essen
Copy link
Collaborator

I suggest that update.sh is broken out to it's own provisioner block and that expect_disconnect is only applied to that.

@cheeseplus
Copy link
Contributor Author

That makes sense and was something I thought about doing but wanted to get the templates unbroken first, optimized later.

@cheeseplus cheeseplus merged commit efdf826 into master Sep 22, 2017
@cheeseplus cheeseplus mentioned this pull request Sep 22, 2017
Closed
@tas50 tas50 deleted the expect-disconnect branch September 22, 2017 04:40
@aia aia mentioned this pull request Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cheeseplus @rickard-von-essen