Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChatProvider getUser should change according to the storage change #2

Closed
Anberm opened this issue Jun 2, 2021 · 2 comments
Closed

ChatProvider getUser should change according to the storage change #2

Anberm opened this issue Jun 2, 2021 · 2 comments
Assignees
@supersnager
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Anberm
Copy link

Anberm commented Jun 2, 2021 •
edited
Loading

image

Similarly, other storage-dependent Callbacks should also change
@Anberm Anberm mentioned this issue Jun 2, 2021
Closed
@supersnager supersnager added bug Something isn't working good first issue Good for newcomers labels Jun 3, 2021
@supersnager
Copy link
Contributor

@Anberm Thank you for the PR. Why have you closed it? Imho this is a bug and should be fixed.

Please check my comment in the PR. I will gladly merge this PR if you will do some changes and reopen it.

@Anberm
Copy link
Author

Anberm commented Jun 3, 2021

@supersnager Yes, this should be fixed. I also modified some codes according to actual needs in the process of using it. I will rearrange the PR after that.

@supersnager supersnager self-assigned this Sep 20, 2021
supersnager added a commit that referenced this issue Sep 20, 2021
@supersnager
fix(provider): #2 added missing callbacks dependencies
5b4042d 
Also fixed some type imports
github-actions bot pushed a commit that referenced this issue Sep 20, 2021
@supersnager
chore(release): 1.0.5 [skip ci]
8346bd9 
## [1.0.5](v1.0.4...v1.0.5) (2021-09-20)

### Bug Fixes

* **provider:** [#2](#2) added missing callbacks dependencies ([5b4042d](5b4042d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supersnager supersnager

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@supersnager @Anberm