Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define default init animation logic to each annotation element #863

Merged
merged 7 commits into from
May 9, 2023
Merged

Define default init animation logic to each annotation element #863

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f18ae0b
Move default init animation logic to each annotation element
stockiNail Mar 8, 2023
696dd7c
move defaults in an inner object of helpers
stockiNail Mar 8, 2023
6d8870b
remove element passed argument
stockiNail Mar 8, 2023
64d5162
fixes JS doc
stockiNail Mar 8, 2023
bcb8310
CC duplications
stockiNail Mar 8, 2023
f65267a
Returned value could be AnnotationElement to animate options
stockiNail Mar 9, 2023
286db9f
Merge remote-tracking branch 'origin/master' into initAnimationInElement
stockiNail Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'origin/master' into initAnimationInElement 
Conflicts:
	types/options.d.ts
  • Loading branch information
@stockiNail
stockiNail committed Mar 16, 2023
commit 286db9f21b819a83a3b5406b17794e7a8f78cebe
2 changes: 1 addition & 1 deletion types/options.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export interface CoreAnnotationOptions extends AnnotationEvents, ShadowOptions,
borderWidth?: Scriptable<number, PartialEventContext>,
display?: Scriptable<boolean, PartialEventContext>,
drawTime?: Scriptable<DrawTime, PartialEventContext>,
init: boolean | ((chart: Chart, properties: AnnotationBoxModel, options: AnnotationOptions) => void | boolean | AnnotationElement),
init?: boolean | ((chart: Chart, properties: AnnotationBoxModel, options: AnnotationOptions) => void | boolean | AnnotationElement),
id?: string,
xMax?: Scriptable<ScaleValue, PartialEventContext>,
xMin?: Scriptable<ScaleValue, PartialEventContext>,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.