Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chartArea not yet available when calling setDataLimits #65

Closed
wants to merge 1 commit into from

Conversation

bendem
Copy link

@bendem bendem commented May 9, 2017

angular.js:14199 TypeError: Cannot read property 'left' of undefined
    at ChartElement.setDataLimits (https://localhost:8003/bower_components/chartjs-plugin-annotation/chartjs-plugin-annotation.js:517:91)
    at ChartElement.initialize (https://localhost:8003/bower_components/chartjs-plugin-annotation/chartjs-plugin-annotation.js:139:9)
    at ChartElement.Chart.Element (https://localhost:8003/bower_components/chart.js/dist/Chart.js:4899:19)
    at ChartElement [as constructor] (https://localhost:8003/bower_components/chart.js/dist/Chart.js:5193:14)
    at new ChartElement (https://localhost:8003/bower_components/chart.js/dist/Chart.js:5193:14)
    at https://localhost:8003/bower_components/chartjs-plugin-annotation/chartjs-plugin-annotation.js:69:20
    at Array.forEach (native)
    at Object.beforeUpdate (https://localhost:8003/bower_components/chartjs-plugin-annotation/chartjs-plugin-annotation.js:63:27)
    at Object.notify (https://localhost:8003/bower_components/chart.js/dist/Chart.js:7346:17)
    at Chart.Controller.update (https://localhost:8003/bower_components/chart.js/dist/Chart.js:4136:16)

@compwright compwright self-requested a review May 20, 2017 16:47
Copy link
Collaborator

@compwright compwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! At a minimum, this would need to be applied to src/types/line.js also. Could you make this change, and provide a CodePen or JSFiddle test case reproducing the problem that this PR fixes?

@compwright
Copy link
Collaborator

Replaced by #80

@compwright compwright closed this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants