Refresh annotations when on config change #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And refactor the plugin for easier reading
|
@etimberg could I get you to review this before I move forward? |
etimberg
reviewed
Nov 19, 2016
| } | ||
| }); | ||
| } | ||
| // Chartjs Zoom Plugin |
There was a problem hiding this comment.
should probably be 'Annotation' not 'Zoom' but that was already there
| drawTime: "afterDraw", // defaults to drawing after draw | ||
| annotations: [] // default to no annotations | ||
| Chart.Annotation.drawTimeOptions = { | ||
| AFTER: 'afterDraw', |
There was a problem hiding this comment.
should not this change in the next release notes as it's a breaking change
| Chart.Annotation.annotationTypes = { | ||
| line: lineAnnotation.Constructor, | ||
| box: boxAnnotation.Constructor | ||
| Chart.Annotation.types = { |
There was a problem hiding this comment.
might be a good idea to store this in a local variable as well to improve minification
let types = Chart.Annotation.types = { ... }
* Don’t break `Chart.Annotation.drawTimeOptions` * Fixed an issue where annotations weren’t rendered if the `drawTime` option was not set * Remove duplicate plugin hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36