Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation option for line labels #178

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

philippemilink
Copy link
Contributor

Hi,

I added a parameter rotate for line labels. As it is named, this parameter allows to rotate the label. I needed this feature to display the label of a vertical line along the line (ie the label is vertical too).

I updated the sample bar to add a demo of this feature.

@joshvillbrandt
Copy link

This is exactly what I needed! I'd love this to be merged and released. Thanks @philippemilink and @benmccann.

@benmccann benmccann merged commit e050a52 into chartjs:master Mar 24, 2020
@benmccann
Copy link
Collaborator

I merged it, but don't have permission to cut a release

@joshvillbrandt
Copy link

Thanks for the quick response, @benmccann!!!

Who can we politely pester to push out a release for us? :)

@benmccann
Copy link
Collaborator

It looks like @compwright is the only person who's ever cut a release in the past. Perhaps @etimberg would be able to help if @compwright is unavailable

@etimberg
Copy link
Member

@benmccann do we know what the release procedure is on this repo? Looks different than elsewhere as there is no release branch. Looks like everything is manual at the moment. Would be best to try and move to the system from the main repo where the built files are not checked in at all

@benmccann
Copy link
Collaborator

Yeah, it looks like it was done manually to me. I'm fine with removing the built files from the repo.

We might be able to copy the release scripts from one of the other plugins. E.g. https://github.com/chartjs/chartjs-adapter-luxon/blob/master/scripts/release.sh

@kurkle kurkle mentioned this pull request Jan 14, 2021
@philippemilink philippemilink deleted the feature-rotate-line-text branch February 21, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants