platform.isAttached should return false if canvas is false-y #11707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
isAttached()
fromplatform.dom.js
should only call_getParentNode()
on valid a truth-ycanvas
value.Current behavior
From sentry:
Reproducible sample
.
Optional extra steps/info to reproduce
No response
Context
_getParentNode
itself. I will defer that decision to the @chartjs maintainers if they want this changed.chart.js version
4.4.2
Browser name and version
Experienced on Chrome 122.0.0 according to my project's Sentry, but probably impacts others since this is missing a null check.
Link to your project
No response