Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative remove docs from publish #10844

Merged
merged 8 commits into from
Nov 1, 2022
Merged

Alternative remove docs from publish #10844

merged 8 commits into from
Nov 1, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleee LeeLenaleee commented Oct 31, 2022 •
edited
Loading

Alternative to #10839 that does work

Resolves: #10835

@LeeLenaleee LeeLenaleee added this to the Version 4.0 milestone Oct 31, 2022
@LeeLenaleee LeeLenaleee changed the title Alternative remove docs Alternative remove docs from publish Oct 31, 2022
@dangreen
Copy link
Collaborator

@LeeLenaleee Hi.

    "files": [
        "auto/**",
        "dist/**",
        "helpers/**",
        "!dist/docs/**"
    ],

Tested locally

@LeeLenaleee
Copy link
Collaborator Author

@dangreen nice catch, works indeed and lot cleaner as my approach 👍🏻

Never would have thought that was possible since it is an include by default :)

@etimberg etimberg requested a review from kurkle November 1, 2022 13:21
@LeeLenaleee LeeLenaleee merged commit 3fea72e into chartjs:master Nov 1, 2022
@LeeLenaleee LeeLenaleee deleted the alternative-remove-docs branch November 1, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: infrastructure
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

package size is more than 20 MB
4 participants
@LeeLenaleee @dangreen @etimberg @kurkle