Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code within table breaks on whitespace #315

Closed
daephx opened this issue Nov 24, 2022 · 3 comments · Fixed by #317
Closed

Inline code within table breaks on whitespace #315

daephx opened this issue Nov 24, 2022 · 3 comments · Fixed by #317

Comments

@daephx
Copy link

daephx commented Nov 24, 2022

A quick search didn't provide me with any relevant issues.
It seems inline code blocks within markdown tables don't have any highlighting and if they contain a whitespace will be rendered as a line break.

xReiYKGTWD

@kunimei
Copy link

kunimei commented Dec 12, 2022

good thankyou

@CheesyChocolate
Copy link

An almost similar Issue is when the code within table has pipe | symbols.

It seems the inline code block is not escaped properly so the pipe | is counted as part of table structure.

| Expression | Value | Type |
| --- | --- | --- |
| `(1 >= 26) || (12 >= 6)`{.java} ||

glow ouput:

pic-selected-240219-0024-34

pandoc markdown ouput:
pic-selected-240219-0024-59

@caarlos0
Copy link
Member

bug lays in glamour, transfering

@caarlos0 caarlos0 transferred this issue from charmbracelet/glow Jul 10, 2024
caarlos0 added a commit that referenced this issue Jul 17, 2024
caarlos0 added a commit that referenced this issue Jul 25, 2024
* wip

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #290

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #312

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #257

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <[email protected]>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Co-authored-by: bashbunni <[email protected]>
bashbunni added a commit that referenced this issue Jul 31, 2024
* wip

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #290

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #312

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #257

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <[email protected]>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Co-authored-by: bashbunni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@caarlos0 @daephx @CheesyChocolate @kunimei and others