Skip to content

Commit

Permalink
Patch grpc for Windows (ray-project#6282)
Browse files Browse the repository at this point in the history
  • Loading branch information
mehrdadn authored and pcmoritz committed Nov 26, 2019
1 parent 1ca8c42 commit 82d1788
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions bazel/ray_deps_setup.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def ray_deps_setup():
remote = "https://github.com/grpc/grpc",
sha256 = "723853c36ea6d179d32a4f9f2f8691dbe0e28d5bbc521c954b34355a1c952ba5",
patches = [
"//thirdparty/patches:grpc-command-quoting.patch",
"//thirdparty/patches:grpc-cython-copts.patch",
],
)
Expand Down
14 changes: 14 additions & 0 deletions thirdparty/patches/grpc-command-quoting.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git third_party/py/python_configure.bzl third_party/py/python_configure.bzl
index 2cb84077e5..e733b9204e 100644
--- third_party/py/python_configure.bzl
+++ third_party/py/python_configure.bzl
@@ -190,7 +190,7 @@ def _get_python_lib(repository_ctx, python_bin, lib_path_key):
"for path in all_paths:\n" + " if os.path.isdir(path):\n" +
" paths.append(path)\n" + "if len(paths) >=1:\n" +
" print(paths[0])\n" + "END")
- cmd = '%s - %s' % (python_bin, print_lib)
+ cmd = '"%s" - %s' % (python_bin, print_lib)
result = repository_ctx.execute([_get_bash_bin(repository_ctx), "-c", cmd])
return result.stdout.strip('\n')

--

0 comments on commit 82d1788

Please sign in to comment.