Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create github release #196

Open
iamyoki opened this issue Jul 13, 2022 · 7 comments
Open

Cannot create github release #196

iamyoki opened this issue Jul 13, 2022 · 7 comments

Comments

@iamyoki
Copy link

iamyoki commented Jul 13, 2022

My release.yml like this:

name: Release
on:
  push:
    branches:
      - "main"

concurrency: ${{ github.workflow }}-${{ github.ref }}

jobs:
  release:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2
      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v2
        with:
          node-version: 16.x

      - name: Install Dependencies
        run: yarn install --frozen-lockfile

      - name: Create Release Pull Request
        uses: changesets/action@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Problem

  • Version Packages PR created but without git tag and github realease

Expected

  • Automatically create git tag and github release
@jjangga0214
Copy link

jjangga0214 commented Jul 15, 2022

I have the same issue. Neither GitHub Release nor git tag is created.

https://github.com/jjangga0214/haetae/runs/7351224812?check_suite_focus=true

This is my public repo's workflow. As you can confirm, it's published but GitHub Releases weren't created. No git tag is created as well.

@iamyoki
Copy link
Author

iamyoki commented Jul 15, 2022

@jjangga0214 Your problem is the same as mine. But publish works for me. You should use changeset publish instead of pnpm publish.

@jjangga0214
Copy link

@iamyoki Thanks for the reply.

I think you misunderstood what I meant.

it's published but GitHub Releases weren't created.

What I meant was that the packages were successfully published to npm. (even with pnpm publish -r)

But GitHub Releases were not created.

@iamyoki
Copy link
Author

iamyoki commented Jul 23, 2022

@jjangga0214 pnpm publish can publish to npm, but not create github release, that's because you didn't use changesets cli to publish and pnpm doesn't have that ability as changesets.

@jjangga0214
Copy link

jjangga0214 commented Jul 23, 2022

@iamyoki
I see. Thanks.
I also of course knew that pnpm publish does not care about changeset.
However, I expected this action to create GitHub Releases under the hood.
As I thought this is the feature of the action, I saw this behavior was a bug.

It seems like I misunderstood.
Has this action actually never provided this feature?
Should this concern be separated as another issue, as a feature request?

@iamyoki
Copy link
Author

iamyoki commented Jul 23, 2022

😆 I think our demands are the same.

@jjangga0214
Copy link

jjangga0214 commented Jul 23, 2022

@mitchellhamilton @Andarist @zkochan

Hi, thankful, dear maintainers!
May I ping you?

I feel GitHub Release should be automatically posted even when a user configures with.publish without changeset publish.

For example, as you can see in my repo, I stick with with.publish: pnpm publish -r because of several benefits pnpm offers, like speed and safe topological order.

I really want changesets/action to post GitHub Release in this case as well.
I believe the action can do that under the hood, without forcing a user to only explicitly depend on changeset publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants