Changesets step does not appear in GitHub Actions log

[aomarks]

When we run changesets/action, the GitHub actions log does not show an entry for the changesets release step itself. This is true both when it succeeds and when it fails. For some reason, the step configured with with: changesets/action@mater never shows up there.

This makes it difficult to understand why the release action failed, because all steps appear to have passed. Only by going to "View raw logs" can we see that an error occured inside the changesets/action step.

Actual result

Failing example: https://github.com/lit/lit/runs/5097382794?check_suite_focus=true
Succeeding example: https://github.com/lit/lit/runs/5098179536?check_suite_focus=true

Expected result

I would expect to see a step called "Create Release Pull Request or Publish to npm" in our action run status.

Workflow

https://github.com/lit/lit/blob/05b5eb227701cf5886e1c193ac6243f8ea991cb8/.github/workflows/release.yaml#L36

- name: Create Release Pull Request or Publish to npm
  id: changesets
  uses: changesets/action@master
  with:
    version: npm run version
    publish: npm run release
  env:
    HUSKY: 0
    GITHUB_TOKEN: ${{ secrets.LIT_ROBOT_AUTOMATION_PAT }}
    NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

[Andarist]

Oh wow, this looks quite weird. This is the first time that I see any action's output being "swallowed" like this. I've rechecked a couple of my repositories that use Changesets and this action is visible in all of the workflow outputs that I've reviewed.

I'm unsure how to approach this - one of the first things that I would try would be to start using @v1 (although I don't see how this would make the things any different). After upgrading (where the upgrade should be seamless as @v1 didn't come with any breaking changes) I would start removing steps/actions in a throwaway PR (basically just bisecting your workflow file). Hopefully, this should show us where the issue might be. If this wouldn't help then I would try to contact GitHub support.

Note that I would try to look into this myself if only I could repro this somehow reliably.

[aomarks]

Oh wow, this looks quite weird. This is the first time that I see any action's output being "swallowed" like this. I've rechecked a couple of my repositories that use Changesets and this action is visible in all of the workflow outputs that I've reviewed.

I'm unsure how to approach this - one of the first things that I would try would be to start using @v1 (although I don't see how this would make the things any different). After upgrading (where the upgrade should be seamless as @v1 didn't come with any breaking changes) I would start removing steps/actions in a throwaway PR (basically just bisecting your workflow file). Hopefully, this should show us where the issue might be. If this wouldn't help then I would try to contact GitHub support.

Note that I would try to look into this myself if only I could repro this somehow reliably.

Thanks for the suggestions @Andarist ! I started pulling out parts of our release script, and it turned out that the problem of the invisible step goes away when we change the id of our step from "changesets" to anything else (using "cs" now): lit/lit#2509

Seems very strange! Maybe it's colliding with some other "changesets" identifier and triggering this bug? 🤷 Seems like it's probably a GitHub Actions bug that we should file, but let me know if this rings any bells.