Change menu item text

[tomquinn04]

No description provided.

[steve-lad]

Thanks Tom,

I agree on the need to have clearer menu titles. This issue dates back a long way and there is little consistency (particularly in the code). My comments:

Setup -> Server Defaults? SetUp implies initialising?
Models and Keysets -> Hardware Defaults
Extensions and Devices -> Extensions and Phones

@dkgroot any comments

[tomquinn04]

maybe if someone has the commercial EPM we could base the structure from that

…

-- Tom

________________________________ From: steve-lad ***@***.***> Sent: Tuesday, June 15, 2021 5:16:42 PM To: chan-sccp/sccp_manager ***@***.***> Cc: 19226484 - Tom Quinn ***@***.***>; Author ***@***.***> Subject: Re: [chan-sccp/sccp_manager] Change menu item text (#19) @steve-lad commented on this pull request. Thanks Tom, I agree on the need to have clearer menu titles. This issue dates back a long way and there is little consistency (particularly in the code). My comments: Setup -> Server Defaults? SetUp implies initialising? Models and Keysets -> Hardware Defaults Extensions and Devices -> Extension and Phones @dkgroot<https://github.com/dkgroot> any comments — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#19 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARHTUUYRFA7QQFARNEQVWDLTS54GVANCNFSM46W5GKIQ>.

[dkgroot]

Hi Steve and Tom

Yes i agree that clear names could help.

Setup -> Server Defaults? SetUp implies initialising?
I would go with "Server Defaults" / "Server Configuration" / "Module Configuration"

Models and Keysets -> Hardware Defaults
This one mostly has to do with Firmware, Provisioning, Keysets. So maybe "Provisioning" sounds about right.

Extensions and Devices -> Extensions and Phones
I am not always happy with the naming in chan-sccp using device and line. But we also want to go for consistency. So may stick with line and device (and live with it). BTW: asterisk calls devices 'endpoints', which would have been a better term.

Extensions in freepbx and asterisk parlance should be reserved for dialplan stuff, i think. Buttons -> Lines on a phone are not related to an extention. And can change behaviour at any time. These things are disjoined and the naming ought to reflect that i think. In simple environments with a couple of phones all the extensions, lines and button assignments might match up nicely (and i love those). But in the business realm you often have to deal with different inside and outside representations for call endpoints causing them to have different extensions and handling. A line is not directly tied to that. It's just a channel via which a channel comes into a phone.

If chan-sccp had called them 'Phone' and 'Extension' then maybe/sure, but that ship has sailed. If you really do want to mix these terms then the page what comes up ought to have a little explanation bubble at the top to explain that:
sccpline = line = extension and sccpdevice = device = phone = endpoint or something, which would be horrible.

So my tip would be go with "Lines and Devices" I know it sucks, but it lines up nicely with what's in the CLI, and sooner or later even freepbx users will have a look at the CLI (I think)

Naming Stuff Is HARD

@tomquinn04 Thank you for your contribution and raising the point. Bit of open discussion via an PR is always welcome.

[tomquinn04]

Extensions in freepbx and asterisk parlance should be reserved for dialplan stuff

@dkgroot
yes - I chose extensions because there is a tab in that page where there is a list of all SCCP extensions, and you can create new SCCP extensions from there.

[dkgroot]

@tomquinn04 Line's and Extensions are not the same thing though. They are related, but that relation can be tight or quite loose, depending on their use / history. For example some voip environments have phones/lines tied to floor and office numbers they are in, but the extensions in that firm are historically tied to the user, in which case they would not resemble each other at all and would be mapped/linked to one another. And to tie it all off the external DID (Direct Inward Dialing) numbers in that firm are not directlly linked to the internal extension so they would be mapped as well. I think it's important to keep these names separately.

I guess i will let steve decide what he want's to do.