Match cursorSave and cursorRestore escape codes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
commented
Oct 27, 2021
Qix-
requested changes
Oct 28, 2021
Co-authored-by: Qix <[email protected]>
SamVerschueren
commented
Oct 28, 2021
Qix-
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Looks good. I'm a bit surprised the regex didn't cover these codes already.
Will defer to @sindresorhus.
SamVerschueren
commented
Oct 28, 2021
jen801
reviewed
Mar 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36
I've added additional tests that iterates over all the
ansi-escapesexported strings and functions. If it's a function, I just pass in some random data.If you want to see something done differently, let me know 🙏 .