Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number input firefox issue #104

Merged
merged 1 commit into from
May 21, 2022
Merged

fix: number input firefox issue #104

merged 1 commit into from
May 21, 2022

Conversation

segunadebayo
Copy link
Member

Closes #103

📝 Description

Fix issue where Firefox doesn't send pointerup event for disabled buttons, requiring an explicit tracking of the disabled state to execute the proper transition.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

🦋 Changeset detected

Latest commit: fed4d69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@zag-js/number-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@segunadebayo segunadebayo changed the title fix: number input issue fix: number input firefox issue May 21, 2022
@segunadebayo segunadebayo merged commit 700378d into main May 21, 2022
@segunadebayo segunadebayo deleted the fix/numberinput branch May 21, 2022 21:00
@github-actions github-actions bot mentioned this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox issue where number input doesn't increment on first attempt after hitting zero
1 participant