-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add time-picker #2583
feat: add time-picker #2583
Conversation
@colinlienard is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
b97effb
to
1a7c336
Compare
1a7c336
to
7c2f607
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks a lot for working on this! I've started reviewing the PR, and it looks very promising. I'm debating whether we should have a dedicated anatomy part for each |
At the start I was thinking that is was more straightforward to have What do you think @cschroeter? |
I've reviewed the PR, and it looks great! Excellent work! However, I noticed some issues when forcing a 24h locale, like I'd like to simplify the API a bit. The Before: <TimePicker.Column unit="hour">
<TimePicker.Spacer />
{api.getHours().map((item) => (
<TimePicker.HourCell key={item.value} value={item.value}>
{item.label}
</TimePicker.HourCell>
))}
<TimePicker.Spacer />
</TimePicker.Column> After: <TimePicker.Column unit="hour">
<TimePicker.Spacer />
{api.getHours().map((item) => (
<TimePicker.Cell key={item.value} value={item.value}>
{item.label}
</TimePicker.Cell>
))}
<TimePicker.Spacer />
</TimePicker.Column> But that's something I can handle myself. Thank you again for your flawless contribution! |
hi @cschroeter when do you plan to release this feature? let us know if we can help on this topic ! :) |
I've updated the React portion but I'm running out of time for Solid and Vue. If you can take those, that would be great. |
Add the
TimePicker
componentContinuation of chakra-ui/zag#1415