Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing var keyword found by lgtm.com #988

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

s0
Copy link
Contributor

@s0 s0 commented Jun 6, 2017

In this code path, html is defined as a global variable rather than a local one, this is probably not what was intended.

This problem was found by lgtm.com: https://lgtm.com/projects/g/chaijs/chai/alerts/

chai is actually in pretty good shape as far as lgtm's default selection of javascript queries are concerned, in fact this is currently the only result that is found. But perhaps it would be of interest to enable PR integration for chai to prevent problems appearing that lgtm's current queries find? You can do this from here: https://lgtm.com/projects/g/chaijs/chai/ci/ And read more about it here: https://lgtm.com/docs/lgtm/config/pr-integration

Full Disclosure: I'm a core developer at lgtm.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants