Assertion subject (obj) changes when using ownProperty assertion #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything about this looks great so far. Look forwarding to seeing a complete PR @lucasfcosta 😄 |
|
Well, I think it's done. |
|
Stellar work as always @lucasfcosta! |
keithamus
added a commit
that referenced
this pull request
Mar 15, 2016
[WIP] Assertion subject (obj) changes when using ownProperty assertion
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve #281.
I've finished the changes to the assertion implementation but I also plan to add this assertion to the
assertinterface (and add tests for that).ownPropertyJSDoc Comments (Examples included)ownPropertyaccepts valueownPropertychanges target (enables chaining)ownPropertytests onshouldinterfaceownPropertytests onexpectinterfaceassertinterfaceownPropertytests onassertinterface