Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed package npm url #1151

Merged
merged 1 commit into from
Apr 3, 2018
Merged

fixed package npm url #1151

merged 1 commit into from
Apr 3, 2018

Conversation

wadie
Copy link
Contributor

@wadie wadie commented Mar 29, 2018

No description provided.

@wadie wadie requested a review from a team as a code owner March 29, 2018 12:32
@codecov
Copy link

codecov bot commented Mar 29, 2018 •
edited
Loading

Codecov Report

Merging #1151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1151   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          32       32           
  Lines        1676     1676           
  Branches      404      404           
=======================================
  Hits         1584     1584           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11612e9...c58133f. Read the comment docs.

astorije
astorije approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👏

@wadie
Copy link
Contributor Author

wadie commented Apr 3, 2018

@astorije can you merge ?

@keithamus keithamus merged commit 1021f40 into chaijs:master Apr 3, 2018
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wadie @astorije @keithamus