Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1145

Merged
merged 5 commits into from
Mar 7, 2018
Merged

Spelling #1145

merged 5 commits into from
Mar 7, 2018

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 6, 2018

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

@jsoref jsoref requested a review from a team as a code owner March 6, 2018 05:04
@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #1145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1145   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          32       32           
  Lines        1676     1676           
  Branches      404      404           
=======================================
  Hits         1572     1572           
  Misses        104      104
Impacted Files Coverage Δ
lib/chai/utils/overwriteProperty.js 95.45% <ø> (ø) ⬆️
lib/chai/utils/overwriteChainableMethod.js 90% <ø> (ø) ⬆️
lib/chai/utils/inspect.js 82.16% <ø> (ø) ⬆️
lib/chai/utils/overwriteMethod.js 100% <ø> (ø) ⬆️
lib/chai/interface/assert.js 89.92% <ø> (ø) ⬆️
lib/chai/utils/transferFlags.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25010c9...541a932. Read the comment docs.

History.md Outdated
* Merge pull request #309 from ericdouglas/iterableEqual-couting-once
* couting variables just once
* Merge pull request #309 from ericdouglas/iterableEqual-couting -once
* couting variables just once
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to change couting to counting , but apparently lost two characters to make that happen :-o

cout is a thing, but I'm prety sure that this code was talking about counting...

@keithamus
Copy link
Member

Hey @jsoref thanks for the PR!

Can we please avoid changing History/Releases - these are legacy files, left for posterity. We should keep them unchanged.

@jsoref
Copy link
Contributor Author

jsoref commented Mar 6, 2018

@keithamus: dropped

@astorije
Copy link
Member

astorije commented Mar 7, 2018

Thanks @jsoref!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants