fix: remove Chai frames from .deep.equal stack
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
+ Coverage 93.68% 93.69% +0.01%
==========================================
Files 32 32
Lines 1646 1649 +3
Branches 396 396
==========================================
+ Hits 1542 1545 +3
Misses 104 104
Continue to review full report at Codecov.
|
|
Wait don't merge this. There's a problem in the logic: it assumes that flag was previously false. I'll fix in a sec... |
d862018
to
2f46af8
Compare
|
Fixed rare edge case where the new logic could disable a previously set flag. |
astorije
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed implementation frames in the
.deep.equalstack trace that @keithamus posted in this comment. Those frames were present because.deep.equalcalled.eqlinternally without locking the SSFI first. There weren't any tests verifying error messages and stack traces (viaerr(fn, msg)) for.deep.equal.