[email protected]

[v1adko]

@keithamus Ran make release-minor, hopefully I've guessed correctly. Decided it's not just a patch because there was a new feature/support added in #994, and not only date fixes, if you disagree I'll update this PR quickly to patch.

[meeber]

LGTM!

[keithamus]

Great work @v1adko!

The last thing we need to create this release is some release notes!

They should follow this format:

New Features

• Feature 1 (#issuenumber, #prnumber)
• Feature 2 (#issuenumber, #prnumber)

Bug Fixes

• Fix 1 (#issuenumber, #prnumber)
• Fix 2 (#issuenumber, #prnumber)

Documentation

• Docs 1 (#issuenumber, #prnumber)
• Docs 2 (#issuenumber, #prnumber)

Here are all of the changes since 4.0.2, so we need to document #988, #990, #992, #993, and #994.

Anyone who would like to write the release notes, please feel free to add as a comment below!

[v1adko]

Here's a pre-filled template (v.0.0.1) :)
This comment should be editable by the maintainers, so feel free.
I'm not yet confident enough to write release notes, so let's crowdsource this.

As for the dates support I've decided that it's a bugfix (returned support of the broken feature), but we can discuss this.

New Features

• Add ES6 collection support to include() (expect(...).to.include should support ES2015 Sets and Maps #970, Add ES6 collection support to include() #994)

Bug Fixes

• Add a missing var keyword found by lgtm.com (Add a missing var keyword found by lgtm.com #988)
• Allow dates for isBelow and isAbove assertions (Error or not updated docs on assert.isAbove and isBelow #980, Allow dates for isBelow and isAbove assertions #990)
• fix: check target's type in .property assertion (fix: check target's type in .property assertion #992)

My guess is that there were no dedicated doc updates? Or does it need a separate PR in the docs
repo?

[v1adko]

@keithamus, @meeber, @vieiralucas Any volunteers to help?)

[cletusw]

Friendly ping.

I understand the desire to have other contributors help with releases, but at some point, maintainers might need to take responsibility for getting things released. This PR includes a fix (#990) for what could be argued to be an accidental breaking change. The fix was merged over two weeks ago and is still waiting for a release.

@keithamus Do you think you could help finish out what remains to be done to get this released? Thanks!

[meeber]

Been on vacay since the 23rd. Should get back home tomorrow night. Will try to carve out some time on Sunday to look at this if no one is able to before then.

[meeber]

I made a couple small changes in-place on @v1adko's release notes (most notably removing reference to the refactor commit since it was a purely internal code update). We currently have a failing build due to an IE11 issue, so I'd like #1005 to get merged (and verify build is passing) before we release this. That commit doesn't need to be mentioned in the release notes. This should be releasable tomorrow evening. I'll try to set aside some time after work.