Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Issue #8 + Misc Updates #10

Merged
merged 10 commits into from
Jul 12, 2023
Merged

Address Issue #8 + Misc Updates #10

merged 10 commits into from
Jul 12, 2023

Conversation

chRyNaN
Copy link
Owner

@chRyNaN chRyNaN commented Jul 12, 2023

This PR resolves Issue #8.

  • Updated Compose Multiplatform to version 1.4.1
  • Created elapsedSystemTime function
  • Removed the kotlinx.datetime dependency and updated NavigationEvent to use milliseconds of elapsed system time
  • Created ContextAndDestination class
  • Replaced NavigationContainer functions with a single NavigationContainer function that uses the ContextAndNavigation class.
  • Updated custom serializers to use CompositeEncoder and CompositeDecoder

Warning! This PR introduces breaking API changes

The NavigationContainer functions were replaced with a single NavigationContainer function that takes a ContextAndDestination class as a parameter to the content closure. This was done because there was confusion about which NavigationContainer function to use before, and using any of them required explicit parameter definitions for the content closure in order for the type system to be able to infer which function was being utilized. The new NavigationContainer function can be used like the following:

NavigationContainer(
    navigator = navigator
) { (context, destination) -> 
    Text("context = $context; destination = $destination")
}

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for contributing! Make sure to follow the project's coding conventions. For a faster response time, consider boosting your issue.

@chRyNaN chRyNaN merged commit f0b2976 into develop Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRITICAL BUG using java.time.Instant which is not available in API below 26
1 participant