Lowered min Android version to 21

chRyNaN · May 22, 2023 · 89c27f1 · 89c27f1
1 parent 40e8c8d
commit 89c27f1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/buildSrc/src/main/java/com.chrynan.navigation.buildSrc/LibraryConstants.kt b/buildSrc/src/main/java/com.chrynan.navigation.buildSrc/LibraryConstants.kt
@@ -16,7 +16,7 @@ object LibraryConstants {
  object Android {
 
  const val compileSdkVersion = 33
- const val minSdkVersion = 23
+ const val minSdkVersion = 21
  const val targetSdkVersion = 33
  }
 }
diff --git a/navigation-core/build.gradle.kts b/navigation-core/build.gradle.kts
@@ -24,7 +24,13 @@ kotlin {
  jvm()
 
  js(IR) {
- browser()
+ browser {
+ testTask {
+ useKarma {
+ useFirefox()
+ }
+ }
+ }
  nodejs()
  }
 

diff --git a/navigation-core/src/commonTest/kotlin/com/chrynan/navigation/NavigationContextStacksTest.kt b/navigation-core/src/commonTest/kotlin/com/chrynan/navigation/NavigationContextStacksTest.kt
@@ -85,7 +85,8 @@ internal class NavigationContextStacksTest {
 
  assertEquals(expected = 2, actual = stack.size)
  assertEquals(expected = TestDestination.CHANNEL_DETAILS, actual = stack.peek())
- assertEquals(expected = TestDestination.FAVORITES, actual = stack.first())
+ assertEquals(expected = TestDestination.CHANNEL_DETAILS, actual = stack.first())
+ assertEquals(expected = TestDestination.FAVORITES, actual = stack.last())
  }
 
  @Test
@@ -111,14 +112,18 @@ internal class NavigationContextStacksTest {
 
  assertEquals(expected = 2, actual = stack.size)
  assertEquals(expected = TestDestination.ITEM_DETAILS, actual = stack.peek())
- assertEquals(expected = TestDestination.HOME, actual = stack.first())
+ assertEquals(expected = TestDestination.ITEM_DETAILS, actual = stack.first())
+ assertEquals(expected = TestDestination.HOME, actual = stack.last())
  }
 
  @Test
- fun pushAllAddsItemsToTopOfStack(){
+ fun pushAllAddsItemsToTopOfStack() {
  val stacks = NavigationContextStacks<TestDestination, TestContext>(initialContext = TestContext.Home)
 
- stacks.pushAll(context = TestContext.Home, destinations = stackOf(TestDestination.ITEM_DETAILS, TestDestination.FAVORITES))
+ stacks.pushAll(
+ context = TestContext.Home,
+ destinations = stackOf(TestDestination.ITEM_DETAILS, TestDestination.FAVORITES)
+ )
 
  val stack = stacks[TestContext.Home].toMutableStack()