Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting <before-dot-space> doesn't produce any effect #18

Closed
cgnieder opened this issue Feb 11, 2019 · 4 comments
Closed

Setting <before-dot-space> doesn't produce any effect #18

cgnieder opened this issue Feb 11, 2019 · 4 comments
Labels
bug Something isn't working minor

Comments

@cgnieder
Copy link
Owner

Original report by Anonymous.


Consider the following code:

===========================================================
\documentclass[a4paper,12pt]{article}
\usepackage{fontspec}
\usepackage[italian]{babel}
\babelfont[italian]{rm}[Ligatures=TeX,Numbers={Proportional,OldStyle},RawFeature=+calt]{Source Serif Pro}
\usepackage{realscripts}
\usepackage[punct-after=true]{fnpct}
\setfnpct{before-dot-space={1em},before-comma-space={1em}}
\usepackage[perpage,bottom,hang,stable,norule]{footmisc}

\begin{document}

Text\footnote{xxxx}. Other text

Text\footnote{xxxx}, other text

\end{document}

The setting before-comma-space produces its effect, the setting before-dot-space none:.

@cgnieder
Copy link
Owner Author

Original comment by Phelype Oleinik (Bitbucket: [Phelype Haron Oleinik](https://bitbucket.org/Phelype Haron Oleinik), ).


The before-dot-space issue is due to a typo while setting the package options. The code for before-dot-space actually does the same as before-comma-space. The option definition is:

    before-dot-space      .code:n     =
      \fnpct_set_punctuation_dim:nnn { before } { , } { #1 } ,

while it should be:

    before-dot-space      .code:n     = %         V
      \fnpct_set_punctuation_dim:nnn { before } { . } { #1 } ,

While this isn't fixed, adding

\ExplSyntaxOn
\keys_define:nn { fnpct }
  {
    before-dot-space      .code:n     =
      \fnpct_set_punctuation_dim:nnn { before } { . } { #1 } ,
  }
\ExplSyntaxOff

after loading fnpct does the trick.

@cgnieder
Copy link
Owner Author

Original comment by M Wemheu (Bitbucket: moewew, GitHub: moewew).


For reference this report originates from https://tex.stackexchange.com/q/474362/

@cgnieder
Copy link
Owner Author

cgnieder commented Oct 4, 2019

Original comment by Clemens Niederberger (Bitbucket: cgnieder, GitHub: cgnieder).


fix issue #18

@cgnieder cgnieder closed this as completed Oct 4, 2019
@cgnieder
Copy link
Owner Author

Original comment by Clemens Niederberger (Bitbucket: cgnieder, GitHub: cgnieder).


Removing version: 0.4 (automated comment)

@cgnieder cgnieder added minor bug Something isn't working labels Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

1 participant