-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdc1d #3
Open
angelcerveraroldan
wants to merge
97
commits into
main
Choose a base branch
from
sdc1d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sdc1d #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added enough to make Python-based access roughly work, so I can play around with the model, eg: import rgrow as rg
tiles = [
rg.Tile([10, 1, 11, 0], name='a', color='red'),
rg.Tile([11, 2, 12, 0], name='b', color='red')
]
ts = rg.TileSet(tiles, model='sdc1d', bonds=[rg.Bond(str(i), 1) for i in range(1, 14)], size=(10, 8))
sys, state = ts.create_system_and_state()
print(sys, state, sep='\n')
print(sys.get_param('energy_bonds')) |
Repository owner
deleted a comment from
codecov-commenter
Jun 16, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Dont need to put scaffold as input (this assumes that sdc system has only one scaffold, which is true as of right now)
By the time update_after_event is run, the canvas has already been updated, and there's no easy way to get what the tile in the point was. More generally, it might be useful to include this in the Event enum, but for now, this change fixes tile counting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.