Johnpipi maxfilesize #2

johnpipi · 2021-01-24T22:11:42Z

added maxFileSize. It will check if the filesize is less than maxFileSize ( in MB ) then skip the rotation.

added maxFileSize. It will check if the filesize is less than maxFileSize then skip the rotation

updated docs for maxFileSize

accept maxFileSize in MB then convert to bytes for the filesize function

cesargb · 2021-01-26T20:32:27Z

Hi @johnpipi , thanks for your PR, this is a good feature.

I wonder if it would be more convenient to move this argument, which is optional, to a setterfunction?

The Api could be something like this:

$rotation->addProcessor(new GzProcessor());
    ->addProcessor(new RotativeProcessor())
    ->size(100)
    ->rotate($fileLog);

In this case, the function that determine this functionality be size, I have taken this name from logrotate: https://linux.die.net/man/8/logrotate

What do you think?

Could you submit these changes?

johnpipi added 3 commits January 24, 2021 14:50

Update Rotation.php

e4d31a9

added maxFileSize. It will check if the filesize is less than maxFileSize then skip the rotation

Update README.md

b575551

updated docs for maxFileSize

Update Rotation.php

284b558

accept maxFileSize in MB then convert to bytes for the filesize function

cesargb changed the base branch from master to v2 March 7, 2021 08:15

cesargb merged commit deba2a8 into cesargb:v2 Mar 7, 2021

Provide feedback