Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast MagicLink's UUID to a string when initially set #113

Closed
wants to merge 1 commit into from

Conversation

rossbearman
Copy link

Resolves #112.

@rossbearman
Copy link
Author

The failing PHPStan test is unrelated to this change.

@rossbearman rossbearman deleted the patch-1 branch April 28, 2024 13:17
@cesargb
Copy link
Owner

cesargb commented Apr 28, 2024

@rossbearman Its true, the fail with PhpStan is not related with this PR.

@cesargb
Copy link
Owner

cesargb commented Apr 28, 2024

@rossbearman Can your reopen this change?

@rossbearman
Copy link
Author

Hi @cesargb, I realised the issue wasn't directly related to laravel-magiclink. The failure was only happening at my end because declare(strict_types=1); was being injected everywhere by a rogue Pint configuration.

The issue isn't present after pulling in a clean version of the package, as LazyUuidFromString gets cast automatically when declare(strict_types=1); isn't present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setMagiclinkId(): Argument #1 ($magiclinkId) must be of type string, LazyUuidFromString given
2 participants