Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(mode): teldat snmp cells-radio #5068

Conversation

garnier-quentin
Copy link
Contributor

@garnier-quentin garnier-quentin commented Jun 21, 2024

Community contributors

Description

The mode teldat snmp cells-radio had been improved. Also windows carriage returns had been removed (\r). Be careful on your development files: the newline should be unix style only.

CTOR-460

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

perl centreon_plugins.pl --plugin=network::teldat::snmp::plugin --mode=cells-radio --snmp-community=public --snmp-version='2c' --hostname=172.30.1.100 --verbose  --filter-interface-type='data primary' --snmp-force-getnext  --custom-perfdata-instances='%(simIcc)%(operator)' --change-perfdata='module.cellradio.(.*),$1,' --filter-perfdata=db
OK: cellular radio module '1' interface 'data primary' [imei: 359072066403100] sim status: OK [operator: BOUYGUES] [imsi: 208209506628100] [interface state: connect(9)] [simIcc: 89332095190662882100] - rsrp: -85 dBm, rsrq: -17 dBm, snr: 8 dB, csq: -48 dBm | '89332095190662882100~BOUYGUES#rsrp.dbm'=-85;;;0; '89332095190662882100~BOUYGUES#rsrq.dbm'=-17;;;0; '89332095190662882100~BOUYGUES#snr.db'=8;;;0; '89332095190662882100~BOUYGUES#csq.dbm'=-48;;;0;
checking cellular radio module '1' interface 'data primary' [imei: 359072066403100]
    sim status: OK [operator: BOUYGUES] [imsi: 208209506628100] [interface state: connect(9)] [simIcc: 89332095190662882100]
    rsrp: -85 dBm, rsrq: -17 dBm, snr: 8 dB, csq: -48 dBm

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

@lucie-dubrunfaut
Copy link
Contributor

I tried to integrate it but the workflow does not seem to work correctly via an external contribution. Here is the link to the new internally open PR containing this branch : #5102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants